Building client master branch with make, does this call to go build:
version information is extracted like this:
However because of how tags are added, the only tag that is present on the master branch is integration-0.1. The release branches 1.0.x were tagged though, but never merged to master. That's why release tags will not be picked up by git describe --tags when building.
Affects versions
None
Environment
None
Checklist
Activity
Show:
Felix RuessJune 6, 2017 at 12:30 PM
Ok, thanks.
Kristian AmlieJune 6, 2017 at 7:49 AM
The problem is that option 1 will break as soon as we branch a version that we release without making any additional fixes (the tag will then be on both branches), which is pretty likely will happen. I would just recommend that you add the old line back in your CI if you need that, like:
Felix RuessJune 2, 2017 at 2:17 PM
Well, not if you just build the current 1.1.x branch, which with option 1 would give me a sensible 1.1.0b1-2-gd4f9db0
Also I'm building mender in our CI, and I have to add a ci yaml file for that... so I can never build these version tags on our ci and get any reasonable version out of it.
With option 1 it would both work on release branches and on master (as long as there is no new tag added matching the regex).
Kristian AmlieJune 2, 2017 at 1:55 PM
You should. Option 4 specifically means that 1.1.0b1 will give you that exact name. Are you not getting that?
Felix RuessJune 2, 2017 at 1:49 PM
Actually option 1 seems to be the most sensible to me...
Building client master branch with make, does this call to
go build:version information is extracted like this:
However because of how tags are added, the only tag that is present on the master branch is
integration-0.1. The release branches1.0.xwere tagged though, but never merged to master. That's why release tags will not be picked up bygit describe --tagswhen building.