mender-convert does not add demo cert to mender.conf

Description

If you run mender-convert with following,

./docker-mender-convert from-raw-disk-image \ --raw-disk-image $RAW_DISK_IMAGE \ --mender-disk-image $MENDER_DISK_IMAGE \ --device-type $DEVICE_TYPE \ --artifact-name $ARTIFACT_NAME \ --bootloader-toolchain aarch64-linux-gnu \ --storage-total-size-mb 4096 \ --demo-host-ip "192.168.1.1" \ --demo

Which is intended to be used together with demo environment, mender-convert will actually produce a invalid "mender-conf",

{ “InventoryPollIntervalSeconds”: 5, “RetryPollIntervalSeconds”: 30, “ServerURL”: “https://docker.mender.io”, “TenantToken”: “Paste your Hosted Mender token here”, “UpdatePollIntervalSeconds”: 5, “RootfsPartA”: “/dev/mmcblk0p2”, “RootfsPartB”: “/dev/mmcblk0p3” }

The missing entry is:

"ServerCertificate": "/etc/mender/server.crt"

Affects versions

None

Environment

None

Checklist

Activity

Show:

Lluis CamposAugust 22, 2019 at 11:32 AM

Done. Closing ticket.

Lluis CamposAugust 22, 2019 at 9:26 AM

Okey, I am cherry-picking this specific change to 1.1.x.

However, as a general rule we don't cherry-pick to old release branches when we have no more bugfix release planned for it (we released already v1.1.0 and v1.1.1, so we do not plan for v1.1.2)

Mirza KrakAugust 22, 2019 at 8:48 AM

Part of 1.2.x release. Needs a cherry-pick to 1.1.x before marking as done. are you doing cherry-picks before final release of 1.2.1?

Mirza KrakAugust 8, 2019 at 6:51 AM

New PR created

Mirza KrakJuly 31, 2019 at 8:29 AM

The mentioned PR does not resolve the case when demo server is used though, but the change would be similar wrapped in a different if statement.

Fixed

Details

Assignee

Reporter

Labels

Priority

Days in progress

0

Backlog

yes

Zendesk Support

Checklist

Created July 10, 2019 at 2:12 PM
Updated June 29, 2020 at 6:32 PM
Resolved August 22, 2019 at 11:32 AM

Flag notifications