mender-grow-data.service fails on GPT images

Description

The following line is causing my eMMC disk expansion to fail (running Yocto Warrior):

mender-client-resize-data-part.sh.in

 Disk expansion was working properly prior to the introduction of this line?

I now get the following error:
The number of cylinders for this disk is set to 240448.
There is nothing wrong with that, but this is larger than 1024,
and could in certain setups cause problems with:

  1. software that runs at boot time (e.g., old versions of LILO)

  2. booting and partitioning software from other OSs
    (e.g., DOS FDISK, OS/2 FDISK)

Command (m for help): The partition table has been altered.

Calling ioctl() to re-read partition table
fdisk: WARNING: rereading partition table failed, kernel still uses old table: Device or resource busy

As a fix for those systems that did not have an issue previously can we suppress the error caused by this line so that the disk expansion can proceed as was previously working?
When I suppress the error caused by:

{all works as it previously did.

Affects versions

Environment

ARM i.MX6 using eMMC

Checklist

Activity

Show:

Kevin GardthausenAugust 5, 2020 at 9:10 AM

Just tested it and it worked for me.

 

Kristian AmlieJuly 21, 2020 at 6:08 AM

Primarily, yes!

Ossian RidayJuly 17, 2020 at 5:02 PM
Edited

@Kristian Amlie Was the request for a pull request directed towards me?

Also it looks like the root cause of the issue is a difference between standard fdisk, and the version of fdisk distributed with BusyBox.

Kristian AmlieJuly 15, 2020 at 7:21 AM

Thanks for investigating, this looks sane to me. Could you post a pull request with that, maybe with a comment why the return code is ignored?

Kevin GardthausenJuly 6, 2020 at 3:25 PM

Can confirm this using yocto-warrior v2.7.4 with a Raspberry Pi 3B+. The workaround also applies here.

Fixed

Details

Assignee

Reporter

Labels

Priority

Days in progress

0

Fix versions

Zendesk Support

Checklist

Created July 2, 2020 at 6:20 PM
Updated June 25, 2024 at 12:02 PM
Resolved August 24, 2020 at 7:44 AM