[mender-connect] Reconnection not happening until a new event is received over D-Bus

Description

If the websocket connections terminates (e.g. deviceconnect gets restarted), mender-connect won't reestablish the connection until a new event is received over the D-Bus channel.

Latest logs from mender-connect:

Reason is here:

  • We send a reconnection event on a channel here, from the main message loop.

  • This message will make needsReconnect to return true once (see here)]

  • needsReconnect is evaluated only if a new JWT token state change is received from dbus, though (see here)]

We should change the logic here to handle the reconnection request even if there is no new JWT token from the Mender client.

Affects versions

None

Environment

None

Checklist

Activity

Show:

Lluis CamposJuly 5, 2021 at 3:29 PM
Edited

Marking it as merged myself.

Does it need cherry-pick to stable branches (old releases, not Mender 3.0.0)? Please follow-up on that, including the changelog PR.

Lluis CamposJuly 5, 2021 at 2:24 PM

Peter GrzybowskiJune 29, 2021 at 6:51 AM

thanks Lucho for keeping track. I am preparing it for review right now.

Luis RamirezJune 28, 2021 at 9:26 PM

Hi folks,

It seems this issue is affecting a customer that he already raised the flag. Do we have any ETA for this pull request to get accepted?

Regards,

Lucho

Fixed

Details

Assignee

Reporter

Labels

Story Points

Priority

Days in progress

0

Backlog

yes

Zendesk Support

Checklist

Created May 13, 2021 at 3:39 AM
Updated June 25, 2024 at 12:02 PM
Resolved July 7, 2021 at 11:05 AM